Skip to content

fix[installer](proxy): leaving auth and validation responsability to … - #2471

Merged
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_log_input_exposure
Aug 14, 2026
Merged

fix[installer](proxy): leaving auth and validation responsability to …#2471
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_log_input_exposure

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🛑 AI review — Sensitive area, extra care recommended

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. Review carefully before merging.

🛑 architecture (gemini-3-flash-lite) — high/critical — please review

Summary: Installer template modification removes authentication header validations for the ingest endpoint.

  • high installer/templates/front-end.go:32 — Removal of API key and connector header validation checks from the reverse proxy configuration breaks public endpoint contract/security expectations and alters the ingress authentication path.

🛑 bugs (gemini-3-flash-lite) — high/critical — please review

Summary: Removal of connector/API key validation logic on the /ingest endpoint creates an authentication bypass.

  • high installer/templates/front-end.go:32 — Removed request validation logic for the /ingest location block (checking connector keys, IDs, types, and API keys). This allows unauthenticated requests to pass directly to the log input service without validation. Ensure this was intentional and replaced elsewhere, otherwise restore the checks.

🛑 security (gemini-3-flash-lite) — high/critical — please review

Summary: Removed authentication and validation header checks from the Nginx /ingest endpoint template, touching security-critical paths.

  • high installer/templates/front-end.go:32 — Removed request validation logic relying on $connector_key_header, $connector_id_header, $connector_type_header, and $api_key_header for the /ingest endpoint. This exposes the log ingestion endpoint without prior authorization checks at the reverse proxy layer. Ensure proper authentication is enforced either upstream or by restoring the Nginx validation rules.

🔴 go-deps — pending updates

🔍 Discovered 30 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/events:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/rule-flood-guard:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/stats:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/feeds:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/alerts:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2/config: v1.32.36 → v1.32.37
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.35 → v1.19.36
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./backend:
     - github.com/aws/aws-sdk-go-v2/config: v1.32.36 → v1.32.37
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.35 → v1.19.36
     - github.com/aws/aws-sdk-go-v2/service/sts: v1.45.5 → v1.45.6
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

❌ Please update dependencies before merging.

@AlexSanchez-bit
AlexSanchez-bit merged commit d0bc30a into release/v12.0.0 Aug 14, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_log_input_exposure branch August 14, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant