Allow authentication for github enterprise - #3064
Merged
Alex Ross (alexr00) merged 2 commits intoOct 28, 2021
Merged
Conversation
|
|
Alex Ross (alexr00)
approved these changes
Oct 28, 2021
Alex Ross (alexr00)
left a comment
Member
There was a problem hiding this comment.
I didn't test whether this fixes enterprise, but I did check that it doesn't break github accounts and fixed an issue with that.
Member
|
Nicholas Latham (@nicholas-l) once you sign the license agreement as requested by the bot I will merge this PR. |
Contributor
Author
|
I have signed the CLA. Also thanks for adding the try-catch, I didn't know it would throw 😃 |
Nicholas Latham (nicholas-l)
deleted the
allow-authentication-for-github-enterprise
branch
November 5, 2021 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a condition for github enterpise session when there is no session for github.com.
I believe this fixes #3056