Skip to content

[RFC PATCH] date: add --date=elapsed and %aX/%cX placeholders - #2368

Open
airvzxf wants to merge 1 commit into
git:masterfrom
airvzxf:feature/date-elapsed
Open

[RFC PATCH] date: add --date=elapsed and %aX/%cX placeholders#2368
airvzxf wants to merge 1 commit into
git:masterfrom
airvzxf:feature/date-elapsed

Conversation

@airvzxf

@airvzxf airvzxf commented Jul 28, 2026

Copy link
Copy Markdown

Motivation

The --date=human format and the %cr/%ch placeholders both produce
a localized English phrase that hides the precise amount of time
that has passed. A commit shown as "2 days ago" may in reality be
1 day 3 hours, or 1 day 23 hours. Switching to %ct and a calculator
solves the problem but is not glance-friendly.

The closest external tool that solves the same problem is
git-log-compact by Kyle J. McKay (2016), which the maintainer
declined to merge into Git core because it was a heavyweight change
to the oneline output rather than a date format.

What this patch adds

A new date format --date=elapsed and --date=elapsed-pad modelled
on uptime(1):

  seconds   --date=elapsed          --date=elapsed-pad
      39    "39s"                   "39s"
     984    "16m 24s"               "16m 24s"
   29268    "8h 7m 48s"             "08h 07m 48s"
 3024000    "1M 5d 0s"              "01M 05d 00h 00m 00s"
60527113    "1y 11M 5d 13h 5m 13s"  "01y 11M 05d 13h 05m 13s"

The padded variant zero-pads every emitted unit to at least two digits.

A commit timestamp that is in the future is reported as "0s", not the
localized phrase "in the future" that show_date_relative() emits.

Months are fixed at 30 days and years at 365 days, matching the
uptime(1) convention. They are consistent, and the same approximations
are already in use by Git's own show_date_relative() for the
relative-time format.

Two new pretty-format placeholders, %aX (author) and %cX (committer):

git log --format='%h (%aX) %s'
13c7afec21 (1d 2h 9s) The 8th batch
8c7817c361 (1y 3d 19h 5m 10s) Merge branch 'rj/meson-libexecdir-fix'
0e521a41b5 (11y 17d 21h 8m 40s) Merge branch 'et/http-proxyauth'

The placeholders mirror %ch and %cr, which also ignore the caller's
--date= and emit a fixed shape.

Open questions

Q1. The placeholder letter. The natural mnemonic is E
(Elapsed), but %aE, %cE and %gE are already taken
(mailmap-respecting email variants). This patch uses X as a free
letter. Would the maintainer prefer a different letter? I am not
attached to X.

Q2. Should --date=elapsed-pad be its own format name, or a
separate --date=elapsed plus a flag? Which mirrors
--date=human / --date=human-local / --date=iso /
--date=iso-local.

Q3. The "future timestamp" behaviour. This patch clamps a future
timestamp to "0s". An alternative would be to keep the relative
format's "in the future" wording.

Q4. %aX/%cX are hard-coded compact; padded output requires
%ad/%cd together with --date=elapsed-pad. Should a
paired %aY/%cY for padded also exist, or is the
asymmetry acceptable?

Patch

The patch modifies the existing date_mode_type enum, adds a new
show_date_elapsed() helper in date.c, wires it through
show_date() and parse_date_format(), exposes two placeholders
via format_person_part() in pretty.c, handles the new format in
builtin/blame.c for column width, updates the documentation, and
adds tests for both the date helper and the pretty-format
placeholder equivalence.

The full patch is attached below.

Testing

$ make DEVELOPER=1 && cd t &&
prove --no-color ./t0006-date.sh ./t4205-log-pretty-formats.sh
./t0006-date.sh ................ ok
./t4205-log-pretty-formats.sh .. ok
All tests successful.

The full test suite (1054 test files, 33832 tests) also passes on
this machine.

Thanks for your time. I am happy to iterate on any of the open
questions before posting a non-RFC version.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gitgitgadget-git

Copy link
Copy Markdown

Welcome to GitGitGadget

Hi @airvzxf, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that either:

  • Your Pull Request has a good description, if it consists of multiple commits, as it will be used as cover letter.
  • Your Pull Request description is empty, if it consists of a single commit, as the commit message should be descriptive enough by itself.

You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net>

NOTE: DO NOT copy/paste your CC list from a previous GGG PR's description,
because it will result in a malformed CC list on the mailing list. See
example.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

@dscho

dscho commented Jul 29, 2026

Copy link
Copy Markdown
Member

@airvzxf please note that the PR description will be sent as kind of a "cover letter" between the diffstat and the patch. It is quite lengthy, and you will see that other PRs in this repository use much more succinct descriptions. Please consider condensing it dramatically (and maybe write it yourself instead of letting an LLM do that, as an LLM-generated cover letter will most likely scare away any potential reviewer, or worse, elicit angry responses?).

@dscho

dscho commented Jul 29, 2026

Copy link
Copy Markdown
Member

/allow

@gitgitgadget-git

Copy link
Copy Markdown

User airvzxf is now allowed to use GitGitGadget.

The --date=human format and the %cr/%ch placeholders both produce
a localized English phrase that hides the precise amount of time
that has passed. A commit shown as "2 days ago" may in reality be
1 day 3 hours, or 1 day 23 hours. Switching to %ct and a calculator
solves the problem but is not glance-friendly.

Add an uptime(1)-style elapsed-time format:
  --date=elapsed          --date=elapsed-pad
  39s                     39s
  8h 7m 48s               08h 07m 48s
  1y 11M 5d 13h 5m 13s    01y 11M 05d 13h 05m 13s

The placeholder letter is X because the obvious choice E is already
used for the mailmap-respecting email variants (%aE, %cE, %gE).

Signed-off-by: Israel Roldan <israel.alberto.rv@gmail.com>
@airvzxf
airvzxf force-pushed the feature/date-elapsed branch from 1f46741 to 48da106 Compare July 30, 2026 04:37
@airvzxf

airvzxf commented Jul 30, 2026

Copy link
Copy Markdown
Author

/preview

@gitgitgadget-git

Copy link
Copy Markdown

Preview email sent as pull.2368.git.git.1785389946001.gitgitgadget@gmail.com

@airvzxf

airvzxf commented Jul 30, 2026

Copy link
Copy Markdown
Author

/preview

@gitgitgadget-git

Copy link
Copy Markdown

Preview email sent as pull.2368.git.git.1785394693090.gitgitgadget@gmail.com

@airvzxf

airvzxf commented Jul 30, 2026

Copy link
Copy Markdown
Author

/submit

@gitgitgadget-git

Copy link
Copy Markdown

Submitted as pull.2368.git.git.1785394879459.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-2368/airvzxf/feature/date-elapsed-v1

To fetch this version to local tag pr-git-2368/airvzxf/feature/date-elapsed-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-2368/airvzxf/feature/date-elapsed-v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants