Fix the condition check for signing EXE - #27827
Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits intoAug 11, 2026
Merged
Fix the condition check for signing EXE#27827Aditya Patwardhan (adityapatwardhan) merged 2 commits into
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
Conversation
Dongbo Wang (daxian-dbw)
requested a review
from Justin Chung (jshigetomi)
as a code owner
August 11, 2026 22:01
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows signing pipeline template so EXE creation/signing logic only runs for the runtimes that actually produce an EXE (x64, x86, arm64), fixing the prior check that didn’t correctly exclude *_minsize runtimes.
Changes:
- Replaced the previous “no-EXE runtimes” list check with an allowlist check for EXE-capable runtimes (
x64,x86,arm64) in the EXE creation step. - Applied the same allowlist check in the EXE recompression step to keep behavior consistent.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Aditya Patwardhan (adityapatwardhan)
approved these changes
Aug 11, 2026
Aditya Patwardhan (adityapatwardhan)
merged commit Aug 11, 2026
7be0df7
into
PowerShell:release/v7.6.5
34 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the condition check for signing EXE.
The MSI and EXE related code was removed from GitHub master, so the min-size package change didn't account for them. The conditional check for creating exe is still using
minsizein the check. Update the check in this PR.