Switch order of module pattern checks for more consistent UMD. - #92
Merged
Conversation
Owner
|
That sounds good, but this change has broken all the tests. Can you take a look at why? I'm happy to merge a change like this, just as long as the tests pass 😄 |
Author
|
Hey - that's because I'm really good at breaking tests inadvertently. Apparently, my copy-paste skills are rusty and my amd definition did not properly parallel what already existed in code. I've updated and local tests went from red to green, so with a little bit of luck, the travis ci build should do the same. |
Owner
|
Looks great, thanks! Merged. |
|
Thanks for this fix! |
Owner
|
All good now; this is now up and released as 1.4.1. Let me know if you have any other trouble. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having errors thrown bundling loglevel in a library that was then being bundled in an application package and found that reversing these checks solves the issue for us.
Based on this conversation: umdjs/umd#22 it seems that checking for AMD before CommonJS is a safer paradigm to follow.