fix: take latest result of run checks - #627
Merged
Merged
Conversation
This make sure we only take into account the latest result of a run, fixing a bug where old failed check runs that are now passing in latest version still breaks the check
|
|
bradh352
added a commit
to c-ares/c-ares
that referenced
this pull request
Jul 3, 2026
## Summary Adds a single **All Checks** aggregator workflow that waits for every *other* check on the PR commit to pass or be skipped, using [poseidon/wait-for-status-checks](https://github.com/poseidon/wait-for-status-checks) (pinned to v0.6.0 + poseidon/wait-for-status-checks#627). This makes it possible to mark just **All Checks** as the required status check on the `main` ruleset: any workflow added (or renamed) in the future is then automatically gated through it — if it fails, this check fails and blocks the PR — with no per-check ruleset edits ever needed. ## Notes - The action ignores itself via `ignore: "All Checks"` (self-ignore isn't automatic once a job `name` is set). - Skipped checks (e.g. path-filtered workflows like Codespell) count as passing. - Timeout is 3 hours to cover the slower emulated/VM jobs (Solaris, NetBSD, OpenBSD, QNX). - After merging, the `main` ruleset's required status checks can be reduced to just `All Checks`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a run check failed, next time we run we take it into account, meaning it will always fail the check
This makes sure we take only the latest version of the run check