Switch to micromatch: fixes yarnpkg/yarn#3336 - #3339
Merged
Conversation
added 2 commits
May 6, 2017 12:44
Test suite now passes
Contributor
Author
|
Unpredictable tests on Travis fail with "timeout" errors: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
at ontimeout (timers.js:386:14)
at tryOnTimeout (timers.js:250:5)
at Timer.listOnTimeout (timers.js:214:5)This failure does not seem to be related to this PR, am I correct? |
reverted registry change
Member
|
Nice, thanks for a thorough explanation, tests and fix |
Contributor
Author
|
@bestander 😰 I just realized that the way I added the extra test causes it to fail on windows in AppVeyor, because I hard coded the path separator |
Member
|
Yeah, could you send a new PR? |
Member
|
@jrop when to expect the PR? |
Contributor
Author
|
@bestander Just submitted. Sorry about that |
Member
|
no worries :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The micromatch library provides an inconsistent implementation of
.makeRe(...)with the rest of it's interface. It is known thatmakeRedoes not produce Regular Expressions that can be trusted:**are not properly converted to regular expressions isaacs/minimatch#67This PR switches from minimatch => micromatch.
Motivation: #3336 😄
Test plan
TODO:
Tested so far: