FYI, the notices that are remaining:

src/uncrustify.cpp(1862): warning (nullPointerRedundantCheck): Either the condition 'ref=ref->GetPrev()' is redundant or there is possible null pointer dereference: ref.
src/keywords.cpp(199): style (unsignedLessThanZero): Checking if unsigned expression 'len' is less than zero.
src/keywords.cpp(217): error (uninitvar): Uninitialized variables: &key.type, &key.lang_flags
src/tokenizer/combine_fix_mark.cpp(1420): style (knownConditionTrueFalse): Condition 'tmp2->IsNotNullChunk()' is always false
src/align/var_def_brace.cpp(129): style (knownConditionTrueFalse): Condition 'pc->IsPreproc()' is always false
src/tokenizer/combine_labels.cpp(285): style (knownConditionTrueFalse): Condition 'tmp->IsNullChunk()' is always false
src/unc_text.cpp(43): style (constParameterReference): Parameter 'c0' can be declared as reference to const
src/align/var_def_brace.cpp(129): style (knownConditionTrueFalse): Condition 'pc->IsPreproc()' is always false
src/tokenizer/mark_question_colon.cpp(147): style (knownConditionTrueFalse): Condition 'pc2->IsNotNullChunk()' is always false
src/tokenizer/mark_question_colon.cpp(102): style (knownConditionTrueFalse): Condition 'colon_found' is always false

I will provide the necessary changes

The checks can already be enabled in the master branch because I've added suppressions to #4494 so that the github actions does not show a failure.

This PR that re-enables these cases in the reports can then be updated with updates from the master branch until all notices are fixed (and this PR can be used to verify it).

PR #4581 is a bug fix proposal.
Please test it and report.

can you solve the problem at
https://github.com/uncrustify/uncrustify/actions/runs/20701078861/job/59423347097?pr=4579

Thanks

@gmaurel

I rebased and the notices below remain.

The followiing could be resolved using a comma operator (ref=ref->GetPrev(), <rest of condition>). The code "as-is" tests that the new ref is not null.

• src/uncrustify.cpp(1862): warning (nullPointerRedundantCheck): Either the condition 'ref=ref->GetPrev()' is redundant or there is possible null pointer dereference: ref.

These need code review/fixes:

• src/tokenizer/combine_fix_mark.cpp(1420): style (knownConditionTrueFalse): Condition 'tmp2->IsNotNullChunk()' is always false
• src/align/var_def_brace.cpp(150): style (knownConditionTrueFalse): Condition 'pc->IsPreproc()' is always false
• src/tokenizer/combine_labels.cpp(285): style (knownConditionTrueFalse): Condition 'tmp->IsNullChunk()' is always false

we need to repair, step by step untill we get info from cppcheck.
I'll change the files.

I fixed a cppcheck notice in md5.cpp (argument can be constant).

A new notice was introduced due to changes, probably #4612 (@PoeticPete ).

src/tokenizer/mark_question_colon.cpp(156): style (knownConditionTrueFalse): Condition 'colon_found' is always false

And I added a definition of "UNCRUSTIFY_VERSION" as an argument to cppcheck to avoid a notice I encountered locally.

Do not make any change at the file [.pre-commit-config.yaml I am working on it, I need about 10 days until I am ready. Thanks

This PR is mainly to verify rhe results of cppcheck.
If you can add the extra option for cppcheck that is useful.

Sorry for the noise!
I don't need any 10 days.
Nobody needs to wait of me.
Sorry

Sorry for the noise! I don't need any 10 days. Nobody needs to wait of me. Sorry

Don't worry, I took it as a notice to not make too many changes to the pre-commit configuration as you are making more in-depth changes). I prefer that.

Result of local execution:

src/tokenizer/mark_question_colon.cpp(156): style (knownConditionTrueFalse): Condition 'colon_found' is always false
src/uncrustify_emscripten.cpp(59): information (missingInclude): Include file: "uncrustify_version.h" not found.
src/uncrustify_emscripten.cpp(176): performance (passedByValueCallback): Function parameter 'tag' should be passed by const reference. However it seems that '_add_keyword' is a callback function.
src/uncrustify_emscripten.cpp(226): performance (passedByValueCallback): Function parameter 'name' should be passed by const reference. However it seems that 'reset_option' is a callback function.
src/uncrustify_emscripten.cpp(252): performance (passedByValueCallback): Function parameter 'name' should be passed by const reference. However it seems that 'set_option' is a callback function.
src/uncrustify_emscripten.cpp(252): performance (passedByValueCallback): Function parameter 'value' should be passed by const reference. However it seems that 'set_option' is a callback function.
src/uncrustify_emscripten.cpp(294): performance (passedByValueCallback): Function parameter 'name' should be passed by const reference. However it seems that 'get_option' is a callback function.
src/uncrustify_emscripten.cpp(116): style (constParameterReference): Parameter 'o' can be declared as reference to const

FYI: I've submitted a PR to fix the cppcheck caching issue with the pre-commit hook.
A temporary solution could be to point to my fork for this fix.

I have finished all the necessary changes.
The test with the file .pre-commit-config.yaml works pretty well for cppcheck.

May I close your call?

@gmaurel I've updated the description of this PR, and squashed my commits.

I am waiting for a PR for the cppcheck hook fixing caching to be accepted in that hook's release. We could temporarily point the hook to my fork of pre-commit-hooks.
This will allow proper caching and increase the speed of the analysis - the "official" version for the cppcheck hook analyses the files one by one, rather than through a single cppcheck call and breaks any caching opportunity.
-> Do we wait, or point to my fork (when integrated we can point back to the upstream)?

The other updates here are the upgrade of some of the other pre-commit hook versions and the update of cppcheck to the latest version which brings some new cases:
And that it enables cppcheck for the big files - which will not be an issue when caching actually works. If this is to be integrated before, I'll remove it again.

src/token_is_within_trailing_return.cpp(16): style (constParameterPointer): Parameter 'pc' can be declared as pointer to const
src/unc_tools.cpp(63): style (constParameterPointer): Parameter 'pc_sub' can be declared as pointer to const
src/unc_tools.cpp(833): style (constVariablePointer): Variable 'pc_saved' can be declared as pointer to const
src/detect.cpp(155): style (constVariablePointer): Variable 'pc' can be declared as pointer to const

Messages like the follwoing are related to the caching limitation of the current cppcheck hook: nofile(0): error (internalError): failed to load '.cache/cppcheck/enum.a1' from '.cache/cppcheck/files.txt'