fix(query-builder): nest child joins only when outer join semantics require it - #12793
Open
lazerg wants to merge 3 commits into
Open
fix(query-builder): nest child joins only when outer join semantics require it#12793lazerg wants to merge 3 commits into
lazerg wants to merge 3 commits into
Conversation
Code Review by Qodo
1.
|
Code Review by QodoNew Review StartedThis review has been superseded by a new analysis |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12792
Description of change
Since 1.1.0 a join gets wrapped in parentheses together with its children whenever it has any, so
leftJoinAndSelect("u.profile", "p").leftJoinAndSelect("p.country", "c")now emitsLEFT JOIN ("profile" "p" LEFT JOIN "country" "c" ON ...) ON ...instead of two flatLEFT JOINs. The nesting was added in #11137 to keep an inner child join from filtering out rows that its outer parent preserves, but it is applied to every combination, including left under left, where flat emission returns exactly the same rows. The parentheses pin the join order, and the reporter saw a seven-table query regress to ~19s averages on PostgreSQL 18 after upgrading.So the parentheses are now gated on the case they were introduced for: an inner child join under a left joined parent. Every other combination goes back to the flat form 1.0.0 emitted. The behaviour tests from #11137 pass unchanged, and the two SQL string assertions that were updated in that PR for a left-under-left chain move back to the flat expectation.
Pull-Request Checklist
masterbranchFixes #NNNN,Closes #NNNN, orResolves #NNNNtests/**.test.ts)docs/docs/**.md) — N/A (no documented behaviour changes, only the emitted SQL shape)