fix: honor take(0) with joins - #12722
Open
GiHoon1123 wants to merge 2 commits into
Open
Conversation
Code Review by Qodoπ Bugs (0) π Rule violations (0) π Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review
|
Author
|
Just checking in on this one. No rush at all, and I'd be happy to make any updates if there's anything else needed from my side. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
take(0)was skipped by the join pagination check because0is falsy.Use null checks so
take(0)enters the pagination path, and cover bothtake(0)andskip(0)with join regression tests.Fixes #12666