Skip to content

DOC clarify random_state recommendations - #34796

Open
dajinzhu wants to merge 1 commit into
scikit-learn:mainfrom
dajinzhu:doc/34641-rephrase-randomness-summary
Open

DOC clarify random_state recommendations#34796
dajinzhu wants to merge 1 commit into
scikit-learn:mainfrom
dajinzhu:doc/34641-rephrase-randomness-summary

Conversation

@dajinzhu

Copy link
Copy Markdown

Fixes #34641.

Rephrase the Recommendation Summary in Common Pitfalls to clearly distinguish integer and RandomState behavior for estimators and cross-validation splitters, following the maintainer direction in the issue discussion.

Validation:

  • sphinx-lint doc/common_pitfalls.rst passed
  • git diff --check passed
  • Full Sphinx build was not available in the preparation environment because sphinx-build was not installed.

@github-actions

Copy link
Copy Markdown

Thank you for opening your first pull request to scikit-learn! πŸŽ‰

To help get your contribution reviewed, please make sure that:

  • You have filled out the pull request template.

  • The pull request addresses an existing issue that is ready for contribution (e.g. not tagged as 'Needs Triage', 'Needs Decision', ...). If you are proposing a new feature, please open an issue to discuss it first.

  • There are no other open pull requests already targeting the same issue.

  • You have followed the pull request checklist. In particular, linting and tests should pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: Add table to Recommendation Summary section in Common Pitfalls

1 participant