Add esc-to-deselect-line feature - #1878
Merged
Merged
Conversation
Member
|
Shouldn't it work on PR diffs too? |
Member
Author
|
Indeed. Currently it only checks for |
Member
|
You can detect it though. Notice how line selections end in |
sindresorhus
approved these changes
Mar 25, 2019
Closed
|
This doesn't work on Chrome for MacOS 74.0.3729.169. I tried viewing a commit and a specific file, neither of them worked. Any tips for Mac users? |
Member
Author
|
It works for me in Firefox and Chrome.
|
|
Unfortunately that still doesn't work. I even tried key combinations like cmd + esc, option + esc, control + esc, and fn + esc. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1590
Test
source/options.html#L1-L2