Flight: bound debugInfo transfer and protect rejectReference against array push errors - #37359
Flight: bound debugInfo transfer and protect rejectReference against array push errors#37359sundeep8967 wants to merge 1 commit into
Conversation
…array push errors
|
Hi @sundeep8967! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
In development mode, resolving large, heavily deduplicated React Flight model graphs can cause
transferReferencedDebugInfoto accumulate_debugInfoarrays beyond V8's array length limit (134,217,728 elements), throwingRangeError: Invalid array length. Furthermore, whenfulfillReferencecatches this and callsrejectReference,rejectReferenceattempts anotherchunk._debugInfo.push(erroredComponent)on the maxed-out array, throwing an unhandled RangeError that obscures the underlying failure.Changes
packages/react-client/src/ReactFlightClient.js:MAX_DEBUG_INFO_ENTRIES = 50000) intransferReferencedDebugInfoto prevent superlinear growth across deduplicated chunks.chunk._debugInfo.push(erroredComponent)in a try-catch inrejectReferenceso error propagation never fails when arrays are full.Fixes #37343