Deprecate ActionDispatch::Http::ParameterFilter in favor of ActiveSup… - #34039
Merged
Conversation
Member
|
This is fine to me. |
…port::ParameterFilter
yskkin
force-pushed
the
parameter_filter
branch
from
October 7, 2018 23:06
fa9a1d2 to
7f80be2
Compare
Contributor
Author
|
@kamipo I just added activesupport's CHANGELOG. |
Contributor
Author
|
CI failure looks unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…port::ParameterFilter
Motivation
AR instance support
filter_parameterssince #33756.Though Regex or Proc is valid as
filter_parameters, they are not supported as AR#inspect.#33756 (comment)
Moving
ParameterFitlerfrom ActionDispatch to ActiveSupport possibly make it easy to solve above issue by sharingParameterFilterwith AR and AD.I'd like to get some feedback before working further on this.