allow '1' or true for acceptance validation. - #18439

We don't need to test this here, it's already covered elsewhere.

How about we just do Array(options[:accept]) instead?

Works for me. I'll update shortly. :)
On Jan 10, 2015 5:07 PM, "Sean Griffin" notifications@github.com wrote:

In activemodel/lib/active_model/validations/acceptance.rb
#18439 (diff):

@@ -20,6 +20,11 @@ def setup!(klass)
klass.send(:attr_reader, *attr_readers)
klass.send(:attr_writer, *attr_writers)
end
+

•  def acceptable_option?(value)
  

•    accept_options = [options[:accept]].flatten
  

How about we just do Array(options[:accept]) instead?

—
Reply to this email directly or view it on GitHub
https://github.com/rails/rails/pull/18439/files#r22763094.

All done. Should I inline the method as well?

Up to you.

I think we should add "true" in the array. e.g. ["1", true, "true"]

I wonder if that would lead to a possible explosion of options. i.e. "True", "TRUE"

Currently, if you need to add additional accept options you can do so.

class User < ActiveRecord::Base
  validates_acceptance_of :terms_and_conditions, accept: ["True", "TRUE", "true"]
end

I would like to keep this change minimal, as I believe TrueClass should be one of the default accept options.

Somebody might using "true" in their test cases. Then what is the purpose for this patch?

I agree with @mokhan, just true is sufficient.

@kuldeepaggarwal - the point is now you can specify an array of acceptable values.

If people were using 'true' before their tests weren't passing, so that's a non issue. Now you will be able to accept ["1", true, "true"] as you suggest by configuring it in the class:

class User < ActiveRecord::Base
  validates_acceptance_of :terms_and_conditions, accept: ["1", true, "true"]
end

You can have it accept anything in the array where before an array wasn't possible, just a single value.