fix(api): reject empty dense vectors in gRPC Vector::Dense validation - #10143
Merged
timvisee merged 1 commit intoAug 12, 2026
Merged
Conversation
Sparse and MultiDense variants already reject empty vectors via validate_sparse_vector_impl / validate_multi_vector_by_length, but Dense always returned Ok(()). Reuse the existing validate_non_empty_dense helper from the REST validation module for consistency.
This was referenced Aug 11, 2026
timvisee
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
devbranch.New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --workspace --all-featurescommand?Changes to Core Features:
What does this PR do?
grpc::vector::Vector::Densewas the only variant of the gRPCVectoroneof that skipped emptiness validation: