Conversation
This switches the nflog to generate Go code via gogoproto and thereby use standard library timestamp types.
mxinden
requested changes
Apr 18, 2017
Contributor
There was a problem hiding this comment.
What's the license on this file?
Contributor
Author
There was a problem hiding this comment.
etcd script: https://github.com/coreos/etcd/blob/master/scripts/genproto.sh
Actually just took it as a skeleton to play around in. No license on this file.
What's the proper way to proceed here in your opinion?
Contributor
There was a problem hiding this comment.
The source repo is all Apache 2.0, so I'd just add a one-line note of where it was originally taken from and under what license.
stuartnelson3
approved these changes
Apr 18, 2017
stuartnelson3
left a comment
Contributor
There was a problem hiding this comment.
Barring the raised license concern, looks cool to me
This generates the protobuf Go code with gogoproto and switches to standard library time types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stuartnelson3 @mxinden
This moves our generated protobuf to gogoproto, which allows us to get rid of the awkward time types. I'd like to get this in before a release of the notification fixes.