Better Google error messages in CE - #4485
Merged
Merged
Conversation
ruslandoga
commented
Aug 29, 2024
|
|
||
| on_ce do | ||
| defp log_ce_error(action, error) do | ||
| Logger.error("Google Analytics 4: Failed when #{action}. Reason: #{inspect(error)}") |
Contributor
Author
There was a problem hiding this comment.
This PR also starts logging errors from Google. But only in CE.
Look like this:
ruslandoga
force-pushed
the
better-errors-on-failed-google-imports
branch
from
August 29, 2024 08:32
f732c7e to
4bee870
Compare
ruslandoga
marked this pull request as ready for review
August 29, 2024 08:32
zoldar
force-pushed
the
better-errors-on-failed-google-imports
branch
from
September 3, 2024 11:38
4bee870 to
1468f9d
Compare
zoldar
approved these changes
Sep 3, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Right now the Google's error message for 401 and 403 responses is replaced by
This error message is not helpful in CE where extra configuration steps are involved.
This PR makes the real error message be displayed in the Plausible CE instead:
It looks ugly but provides valuable information.
Tests
Changelog
Documentation
Dark mode