Skip to content

Add browser icons - #4239

Merged
ukutaht merged 6 commits into
masterfrom
add-browser-icons
Jun 18, 2024
Merged

Add browser icons#4239
ukutaht merged 6 commits into
masterfrom
add-browser-icons

Conversation

@ukutaht

@ukutaht ukutaht commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Changes

Adds icons for popular browsers, including a fallback for when we don't have an icon (ex: Android Browser below)

Screenshot 2024-06-17 at 16 57 28

Tests

  • This PR does not require tests

Changelog

  • [c] Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

'Chrome': 'chrome.svg',
'Safari': 'safari.svg',
'Firefox': 'firefox.svg',
'Edge': 'edge.svg',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that one "Microsoft Edge"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. The seeds misled me, I've fixed them here: f8b4a4e

@ukutaht
ukutaht merged commit 0060954 into master Jun 18, 2024
@ukutaht
ukutaht deleted the add-browser-icons branch June 18, 2024 09:45
@ukutaht ukutaht mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants