docs: rename secret to salt - #6813
Open
kevinschweikert wants to merge 1 commit into
Open
Conversation
the moduledocs even say that the second argument is a "cryptographic salt" so we should name the arg as such.
Member
|
We take it from plug_crypto (https://plug-crypto.hexdocs.pm/Plug.Crypto.html#decrypt/4), so I guess we should first change it there? |
Contributor
Author
|
Totally! I peeked at the implementation and its even shadowing the actual def decrypt(key_base, secret, token, opts)
when is_binary(key_base) and is_binary(secret) and is_list(opts) do
secret = get_secret(key_base, secret, opts)
I will open a PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the moduledocs even say that the second argument
is a "cryptographic salt" so we should name the arg as such.
Also
verify/4andsign/4call itsalt