fix: keep severity calibration consistent across scan modes - #737
Draft
cjc0013 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deep reduction could silently assign a different severity from Standard scan findings even when the underlying evidence was materially equivalent. This change preserves equivalent calibration and requires evidence-backed explanations when a reducer changes or reconciles severity.
Closes #671.
Changes
severity.rationaleandseverity.changeConditionswhen source severities conflict or the output changes their calibrationValidation:
Passed:
cmd.exe /d /c pnpm --dir sdk/typescript run build:plugincmd.exe /d /c node plugins/codex-security/mcp-app/tests/test_artifact_deep_reducer.mjspnpm --dir sdk/typescript run test:mcpnpm --prefix plugins/codex-security/mcp-app run typecheckpython -m ruff check --config plugins/codex-security/pyproject.toml .github/scripts/check_plugin_source_compatibility.py .github/scripts/test_check_plugin_source_compatibility.py plugins/codex-securitypython -m ruff format --check --config plugins/codex-security/pyproject.toml .github/scripts/check_plugin_source_compatibility.py .github/scripts/test_check_plugin_source_compatibility.py plugins/codex-securitypython .github/scripts/check_plugin_source_compatibility.pyRisk and rollout
The new check applies only after Deep reduction has retained and validated source-finding provenance. Existing reductions that preserve a unanimous source severity are unchanged. A reducer that changes severity or resolves conflicting source severities without the required explanation now fails closed and can be retried with the missing evidence fields.
Prior work and attribution
Public disclosure review