fix(plugin): include PowerShell module and data files - #715
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
CI follow-up for
All three required checks now pass. The published head and checked-out source were unchanged; no workflow, test expectation, or timeout was changed for the rerun. The reason for the earlier deadline overrun remains unknown, and the differently seeded successful run does not establish its cause. |
Summary
Extend the PowerShell file coverage added in #707: the shared text-extension list includes
.ps1, but still omits.psm1script modules and.psd1manifests/data files. Otherwise eligible files of these types are skipped by automatic diff-inventory and rank-input selection.Explicit files supplied through a scopes file can already bypass extension filtering; this is not a claim that these file types cannot be targeted by any route.
Changes
.psm1and.psd1to the existing sharedTEXT_CODE_EXTENSIONSset..ps1and JSON controls.Testing
On native Windows with Python 3.12.13 and pytest 9.0.3:
.ps1/JSON regression passed on the unchanged production code.python -B -m pytest -q tests/test_generate_in_scope_files.py tests/test_generate_rank_input.py tests/test_rank_preview.py(with isolated temporary/cache directories and JUnit output): 115 passed, 2 skipped. Both skips are existing executable-script-shim cases unsupported on Windows.git diff --check: passed.The full TypeScript suite was not rerun locally for this Python-only selection change. Hosted CI at
34d06afpassed all three required checks and all 28 node-ci jobs, including all 18 Windows jobs; the other four applicable workflows also passed.Risk and rollout
Automatic selection will include these additional source/configuration files on all host platforms, so affected repositories may produce more candidates.
Files remain data: they are not imported or executed by PowerShell. No commands, flags, execution-policy settings or sandbox behavior change. Existing excluded-path, binary-content and file/path checks remain in place. This does not add UTF-16 decoding; the existing NUL-byte filter still excludes UTF-16 files. That separate decoding fix is in #716. No data migration is required.
Public disclosure review