fix(windows): honor dedupe environment settings - #696
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba42078092
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
The deduplication review runner copies the environment into a plain object, losing Windows' case-insensitive lookup behavior. Differently cased API-key and home-directory settings then stop working as intended. An empty primary key also hides a valid alternate key, and empty home settings should use the existing default directories.
Changes
Testing
codex-reviewandscan-comparisonsuites: 37 passed, 1 existing Windows skip, 0 failed; 178 assertions, seed1266991936.Risk and rollout
Small caller-level environment changes; the shared helper retains exact-key precedence and case-sensitive behavior on other platforms. Nonempty path values are preserved. No new CLI surface, default sandbox change, migration or release step is introduced. These focused checks do not establish full model-backed deduplication or sandbox enforcement.
Public disclosure review