events: fix addAbortListener for aborted signals - #65640
Open
lazerg wants to merge 1 commit into
Open
Conversation
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
lazerg
force-pushed
the
fix/issue-65637-abort-listener-disposal
branch
from
August 29, 2026 08:47
1830f2a to
eca0fdb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65640 +/- ##
==========================================
+ Coverage 90.04% 90.06% +0.01%
==========================================
Files 754 754
Lines 255722 255738 +16
Branches 48312 48311 -1
==========================================
+ Hits 230274 230320 +46
+ Misses 16553 16544 -9
+ Partials 8895 8874 -21
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
addAbortListener()is given a signal that is already aborted, it queueslistener()with no arguments and leaves the returned disposable empty. So the callback getsundefinedwhere every other path hands it theabortevent, and disposing before the microtask runs does not stop it from firing.The aborted branch now builds a trusted
abortevent with the same target and dispatch state the real listener would see, and its dispose handler cancels the pending microtask.Fixes #65637