Skip to content

test: update WPT for streams to 4832db4761 - #65638

Open
standard-Chan wants to merge 2 commits into
nodejs:mainfrom
standard-Chan:test-update-streams-wpt
Open

test: update WPT for streams to 4832db4761#65638
standard-Chan wants to merge 2 commits into
nodejs:mainfrom
standard-Chan:test-update-streams-wpt

Conversation

@standard-Chan

@standard-Chan standard-Chan commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Update the streams Web Platform Tests to upstream commit 4832db4761.

The streams WPT were last updated in nodejs/node#62864 in April 2026, so this brings the vendored tests up to a more recent upstream revision.

This also updates the streams WPT status entries for owning-type tests that were renamed upstream from .any.js to .tentative.any.js.

Related upstream rename PR

Validation

$ tools/test.py wpt/test-streams
[00:05|% 100|+   1|-   0]: Done

All tests passed.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. web streams Issues and PRs related to the Web Streams API. labels Aug 29, 2026
Update the streams Web Platform Tests to upstream commit
4832db47614f5f48cc57374cbf5c1f70937fad48.

Adjust the streams WPT status entries for owning-type tests
that were renamed to tentative files upstream.

Signed-off-by: Jeong SeokChan <starp321@naver.com>
@standard-Chan
standard-Chan force-pushed the test-update-streams-wpt branch from 1a7ee9b to 43ab95b Compare August 29, 2026 07:57
@panva

panva commented Aug 29, 2026

Copy link
Copy Markdown
Member

Usually we'd do this with our WPT updater workflow but since this also needs an expectation update it's fine 👍 I checked the exact sha to match what's in the PR.

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files: 144/152 ran, 138 passed, 8 skipped, 4 expected failures, 2 unexpected failures, 0 unexpected passes
Subtests: 2812 passed, 0 skipped, 14 expected failures, 2 unexpected failures, 0 unexpected passes
  "readable-streams/from.any.html": {
    "fail": {
      "unexpected": [
        "ReadableStream.from throws on invalid iterables; specifically a string"
      ]
    }
  },
  "readable-streams/from.any.worker.html": {
    "fail": {
      "unexpected": [
        "ReadableStream.from throws on invalid iterables; specifically a string"
      ]
    }
  },

Please acknowledge these failures and open an issue or if you feel like it a followup PR to fix them

Add the ReadableStream.from()	string invalid iterable test to the
streams WPT expected failures.

Signed-off-by: Jeong SeokChan <starp321@naver.com>
@panva panva added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 29, 2026
@standard-Chan

Copy link
Copy Markdown
Contributor Author

Thanks for pointing this out. I've updated streams.json to mark these tests as expected failures.

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (7b0de5e) to head (dcece85).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65638   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files         754      754           
  Lines      255722   255722           
  Branches    48314    48320    +6     
=======================================
+ Hits       230281   230298   +17     
+ Misses      16555    16549    -6     
+ Partials     8886     8875   -11     

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. web streams Issues and PRs related to the Web Streams API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants