Add media query support - #118
Merged
Martin Aeschlimann (aeschli) merged 5 commits intoJun 2, 2025
Merged
Conversation
Contributor
|
Very cool! The schema is https://github.com/microsoft/vscode-css-languageservice/blob/main/docs/customData.schema.json |
Martin Aeschlimann (aeschli)
approved these changes
Jun 2, 2025
Martin Aeschlimann (aeschli)
enabled auto-merge (squash)
June 2, 2025 11:23
Contributor
|
Ah, I see you updated the schema as well. Fantastic! |
Daniel Imms (Tyriar)
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue: microsoft/vscode-css-languageservice#197
CSS language server PR: microsoft/vscode-css-languageservice#443
So microsoft/vscode-css-languageservice#256 has not been updated for almost 4 years now, and I would like to push this forward
This change pulls in the media query data from the
@webref/csspackage maintained by W3C since this data is not available from MDN, also I saw some discussion about switching to use it in #76, so I would assume it's fine to use it hereI'm not entirely sure how should I update the schema though