feat: add source line number toggle - #5111
Open
masalha-alaa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4033
Summary
Adds a View → Toggle Line Numbers option directly below Toggle Table of Contents.
The option shows or hides line numbers in Source Code Mode. When enabled, every line is numbered using CodeMirror’s existing line-number font and color. The preference is persisted and defaults to enabled to preserve the existing behavior.
Locale entries and automated tests are included.
Type of change
Test plan
Automated validation completed:
Notes for reviewers [optional]
The focused E2E test covers menu placement, checked state, live hiding and showing, and sequential line numbering. It is included but could not be executed because of the sandbox limitation described above.
By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](LICENSE).