Fix SMTP notification timeouts - #5591
Open
justadityaraj wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An unreachable SMTP server could leave
smtp.SendMailblocked forever. Repository-server clients then waited for the synchronous notification RPC even after their snapshot had completed.Fix
Replace the context-free SMTP helper with the equivalent client sequence over a context-aware dialer, including the existing STARTTLS and AUTH behavior. A 10-second deadline now bounds the connection and every SMTP protocol operation; an earlier caller deadline still wins. No asynchronous delivery or new configuration was added.
Fixes #5563.
User impact
A broken or blackholed SMTP notification endpoint now fails the notification after a bounded interval instead of wedging snapshot completion indefinitely.
Verification
masterat its one-second guard and passes with this change, returningcontext.DeadlineExceeded.go test ./notification/... -count=1go vet ./notification/...git diff --check