fix(cli): report invalid log levels for maintenance runs - #5586
Open
justadityaraj wants to merge 1 commit into
Open
fix(cli): report invalid log levels for maintenance runs#5586justadityaraj wants to merge 1 commit into
justadityaraj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
maintenance run --safety=nonecould replace an invalid global flag error with the unrelatedunhandled safety levelmessage because the safety flag's backing value remained empty until Kingpin applied its default.Changes
Initialize the backing value to the safety flag's documented default before parser hooks run, and cover the invalid log-level path with a regression test.
User impact
Invalid log levels used with maintenance runs now report the allowed values so the flag can be corrected directly.
Verification
go test ./cli -run '^TestMaintenanceRunReportsInvalidGlobalFlag$' -count=1 -vgo test ./cli -count=1go vet -all ./cligolangci-lint run ./cli/...gopls check cli/app.go cli/command_maintenance_run_test.goFixes #4008