fix(cli): mark snapshot verify --parallel as deprecated and no-op - #5552
Open
v3t3a wants to merge 1 commit into
Open
fix(cli): mark snapshot verify --parallel as deprecated and no-op#5552v3t3a wants to merge 1 commit into
snapshot verify --parallel as deprecated and no-op#5552v3t3a wants to merge 1 commit into
Conversation
`--parallel` has had no effect on `snapshot verify` since kopia#1921, which merged the tree-walk and file-verification parallelism into the single `VerifierOptions.Parallelism` field and wired it to `--file-parallelism`. `verifyCommandParallel` has had no reader since then: the flag parses, advertises a default of 8, and is silently discarded. The Consistency documentation page still recommends `--parallel=10` in four places, so users following it believe they are tuning something. Follow the existing convention in this file for `--all-sources`: hide the flag, label it as having no effect, and log a deprecation message when it is passed. Dropping `Default("8")` lets the zero value distinguish an explicit `--parallel` from an absent one, and stops the help text from advertising a default that does nothing. The flag still parses, so existing scripts and cron jobs keep working. Restoring a separate tree-walk parallelism knob would be the alternative fix, but that reverses a deliberate simplification and changes the public `snapshotfs.VerifierOptions` surface, so it is left to maintainers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--parallelhas had no effect onsnapshot verifysince #1921, which merged the tree-walk and file-verification parallelism into the singleVerifierOptions.Parallelismfield and wired it to--file-parallelism.verifyCommandParallelhas had no reader since then: the flag parses, advertises a default of 8, and is silently discarded.The Consistency documentation page still recommends
--parallel=10in four places, so users following it believe they are tuning something.Follow the existing convention in this file for
--all-sources: hide the flag, label it as having no effect, and log a deprecation message when it is passed. DroppingDefault("8")lets the zero value distinguish an explicit--parallelfrom an absent one, and stops the help text from advertising a default that does nothing. The flag still parses, so existing scripts and cron jobs keep working.Restoring a separate tree-walk parallelism knob would be the alternative fix, but that reverses a deliberate simplification and changes the public
snapshotfs.VerifierOptionssurface, so it is left to maintainers.