publish container images to ghcr as well - #5546
Open
aslilac wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Publishes Kopia container images to GitHub Container Registry alongside Docker Hub.
Changes:
- Adds GHCR authentication and image tags.
- Grants workflow package publishing permissions.
- Moves Docker registry login into the publishing script.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tools/docker-publish.sh |
Authenticates and publishes multi-architecture images to both registries. |
Makefile |
Delegates registry authentication to the publishing script. |
.github/workflows/make.yml |
Supplies GHCR credentials and package permissions. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a slight preference for using ghcr images when possible, because they're easier to discover without needing to leave github, and it's easier to see that the image is controlled by the same person/set of people as the codebase itself. I'm sure there are others feel the same. :)
so, I propose a small tweak to the scripts involved to publish future image tags to ghcr, in addition to the current docker hub image