Skip to content

Documents parseHtmlFragment and setHtml - #2129

Open
manrajgrover wants to merge 2 commits into
knockout:masterfrom
manrajgrover:adds-utils-documentation
Open

Documents parseHtmlFragment and setHtml#2129
manrajgrover wants to merge 2 commits into
knockout:masterfrom
manrajgrover:adds-utils-documentation

Conversation

@manrajgrover

Copy link
Copy Markdown

This PR documents ko.utils.parseHtmlFragment and ko.utils.setHtml.

brianmhunt added a commit to knockout/tko.utils that referenced this pull request Oct 3, 2016
Prefer <template> tags over jQuery for setHtml.
@manrajgrover

Copy link
Copy Markdown
Author

@brianmhunt Looks like Travis Build didn't pass. I feel this is because of the warning. Some insights and help would be required.

@brianmhunt

Copy link
Copy Markdown
Member

@manrajgrover tko.utils (where this was merged) passes: https://circleci.com/gh/knockout/tko-policy

There are a long list of build & testing issues with knockout. See e.g. #1360 .

@mbest

mbest commented Oct 5, 2016

Copy link
Copy Markdown
Member

The build failed with "The following files have trailing spaces that need to be cleaned up". Why does this fail the build? It's to prevent files with trailing spaces from being checked in so that later on, editors that automatically remove trailing spaces don't cause superfluous changes.

@manrajgrover

Copy link
Copy Markdown
Author

@brianmhunt I'll have a look at the PR. So, contributions should now be make to tko.utils?

@mbest I'll take care of that in future contributions. 😅

@chrisknoll

Copy link
Copy Markdown

This probably would have failed on the TKO side if the TKO required those trailing spaces to be fixed (if I'm reading that correctly). I wouldn't base where to place pull requests based on those guidelines.

@brianmhunt: if it's technically knockout, shouldn't that apply to these sorts of test considerations as well?

@brianmhunt

Copy link
Copy Markdown
Member

Yes, we will have an eslint test on checking for the tko family of packages too at some point. :)

brianmhunt added a commit to knockout/tko that referenced this pull request May 8, 2017
Prefer <template> tags over jQuery for setHtml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants