Skip to content

fix: Issue with Fixed Term subscriptions created with 0.22.x - #2309

Open
Roshan931 wants to merge 1 commit into
killbill:masterfrom
Roshan931:prilog/fix-error-legacy-fixedterm-subscriptions-have-no-08-21-2026-1a8b9e
Open

fix: Issue with Fixed Term subscriptions created with 0.22.x#2309
Roshan931 wants to merge 1 commit into
killbill:masterfrom
Roshan931:prilog/fix-error-legacy-fixedterm-subscriptions-have-no-08-21-2026-1a8b9e

Conversation

@Roshan931

Copy link
Copy Markdown

Fixes #1909

Root cause

Legacy FIXEDTERM subscriptions have no EXPIRED event, so billing never stops

Changes

  • In DefaultSubscriptionBase.getSubscriptionBillingEvents, when no CANCEL/EXPIRED transition exists and the last Plan/PlanPhase transition lands on the plan's final FIXEDTERM phase, derive an EXPIRED billing event at phaseStart + phase duration (dropping catalog-version change candidates at/after that date), which stops billing exactly like the persisted EXPIRED event does for subscriptions created with 0.24.x. Added fast regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with Fixed Term subscriptions created with 0.22.x

1 participant