Skip to content

fix: NullPointerException in Catalog Validation when there is a phase mismatc... - #2308

Open
Roshan931 wants to merge 1 commit into
killbill:masterfrom
Roshan931:prilog/fix-error-validation-messages-dereference-plan-08-21-2026-db548e
Open

fix: NullPointerException in Catalog Validation when there is a phase mismatc...#2308
Roshan931 wants to merge 1 commit into
killbill:masterfrom
Roshan931:prilog/fix-error-validation-messages-dereference-plan-08-21-2026-db548e

Conversation

@Roshan931

Copy link
Copy Markdown

Fixes #1945

Root cause

Validation messages dereference plan.getCatalog() on a deserialized catalog whose root is null

Changes

  • Build the 'version' portion of the phase-shape and phase-duration validation messages from the StaticCatalog being iterated (its effectiveDate survives Externalizable cloning) instead of plan.getCatalog().getEffectiveDate(), which is null on the cloned catalog produced in DefaultCatalogUserApi.validateCatalogInternal. Added a regression test plus two minimal catalog versions with a mismatched final phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException in Catalog Validation when there is a phase mismatch

1 participant