Allow to set relationship ids dynamicly - #145
Open
povilasjurcys wants to merge 1 commit into
Open
Conversation
Collaborator
|
@povilasjurcys thank you for the PR, but my current focus is on the #141 where a big rewrite is ongoing. This covers the use-case you are describing as well here: Basically, the new version will consider only the This should drastically simplify the API, codebase and maintain the flexibility. I know the docs are still a bit of an in-progress, but if you could give #141 a test I'll appreciate any feedback. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently, we can set the relationship
id_method_nameonly as a symbol or string. This does not work well when you want to use custom id value, because you have to create method with same value on object class, aka put serialization logic in to non-serializer class. Example:What is the new behavior?
This PR allows to set
id_method_nameas a lambda/Proc so custom id logic can be defined directly in serializer:With lambda value,
id_method_namekey is a bit misleading, but I want to make this change as small as possible. Key renaming, deprecation & co might be done with separate PR.Checklist
Please make sure the following requirements are complete:
features)