refactor: migrate resource_github_user_ssh_key to tflog - #3601
Open
nivedmahendran wants to merge 1 commit into
Open
refactor: migrate resource_github_user_ssh_key to tflog#3601nivedmahendran wants to merge 1 commit into
nivedmahendran wants to merge 1 commit into
Conversation
Replace the standard log package with HashiCorp's tflog, and migrate CRUD functions to Context-aware variants returning diag.Diagnostics. Part of integrations#3070, paired with integrations#2996.
|
π Hi, and thank you for this contribution! This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can. You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions. π€ This is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3070
Migrates logging in
resource_github_user_ssh_key.gofrom the standardlogpackage totflog, and migrates the CRUD functions to Context-aware variants (CreateContext/ReadContext/DeleteContext) returningdiag.Diagnostics(paired with #2996).Changes:
log.Printf("[INFO] ...")with structuredtflog.Info(ctx, ...)including thessh_key_idfielderrorreturns converted todiag.FromErrctxId/ctxEtagcontext valuesVerified with
gofmt,go build ./..., andgo vet ./....