Skip to content

Transpile module output for package.json - #57

Open
farneman wants to merge 1 commit into
hyperform:masterfrom
farneman:transpile-module-output
Open

Transpile module output for package.json#57
farneman wants to merge 1 commit into
hyperform:masterfrom
farneman:transpile-module-output

Conversation

@farneman

@farneman farneman commented May 7, 2017

Copy link
Copy Markdown
Contributor

This fixes #56 by adding an ./es directory that is created via NPM's prepare command on publish and install. The files from ./src are transpiled to ES5 there via Babel while keeping the module syntax.

I also added a similar command to the Makefile if it's helpful. I'm not very familiar with JSPM or its use of Makefiles so let me know if that needs to be changed or removed.

@farneman
farneman force-pushed the transpile-module-output branch from c0ba525 to 80fc0de Compare May 20, 2017 14:04
@farneman

Copy link
Copy Markdown
Contributor Author

Updated to fix conflicts with the current master.

@iptpv

iptpv commented Jun 20, 2017

Copy link
Copy Markdown

πŸ‘

@TheRealAlan

Copy link
Copy Markdown

We ran into an issue where the es2015 version was always automatically used, even with the .cjs version should have been, which may or may not have been caused by this. Is there a reason why this PR was never merged?

@jan-dh

jan-dh commented Jun 22, 2018

Copy link
Copy Markdown

I'm running into an issue with ES2015 version as well (using webpack 4 and the import statement). Can anyone confirm if this PR solves this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package.json module property reference should not include ES2015+ features

4 participants