fix: avoid database deadlock in GetParticipantsByIssueID() - #8395
Open
crd477 wants to merge 1 commit into
Open
Conversation
Change `mailParticipants()` to pass Engine `e` into `mailIssueCommentToParticipants()` and subsequently `GetParticipantsByIssueID()`. This allows `GetParticipantsByIssueID()` to use the session created in `CreateComment()` to issue the database query, avoiding a deadlock. This is a patch for gogs#8375, and was authored by @chuckcranor Signed-off-by: Chad Dougherty <crd477@icloud.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents SQLite deadlocks when notifying issue participants by reusing the active comment transaction.
Changes:
- Passes the active database engine through mail notification functions.
- Queries participants using that engine.
- Documents the fix in the changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/database/issue.go |
Uses the provided engine for participant queries. |
internal/database/issue_mail.go |
Propagates the engine through notification handling. |
internal/database/comment.go |
Passes the active comment session to notifications. |
CHANGELOG.md |
Adds the fix entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Fixed | ||
|
|
||
| - Fix database deadlock in mail notifications for comments. [#8375](https://github.com/gogs/gogs/issues/8375) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fix a database deadlock in
GetParticipantsByIssueID().Change
mailParticipants()to pass Engineeinto
mailIssueCommentToParticipants()and subsequentlyGetParticipantsByIssueID(). This allowsGetParticipantsByIssueID()to use the session created inCreateComment()to issue the database query, avoiding a deadlock.This is a patch for #8375, and was authored by @chuckcranor
Checklist
Test plan
ENABLE_EMAIL_NOTIFICATIONby setting: