Fix repository wiki markdown links - #8352
Conversation
|
Please use PR template and reopen the PR. |
|
Updated the PR body with the repository pull request template and reopened it. Thanks for the guidance. |
|
Quick correction: I updated the PR body to match the repository pull request template, but GitHub did not allow me to reopen the PR from my side. Could a maintainer reopen it, or would you prefer that I open a fresh PR with the same branch and template body? |
|
Follow-up: this original PR is open again, and the pull request body now uses the repository template with the test plan included. I also closed the duplicate replacement PR #8358 to keep the review focused here. Could you please continue the review on this PR when convenient? |
|
Follow-up: PR #8352 is open again and the body follows the repository PR template, including the checklist and targeted/full markup tests. The CHANGELOG checkbox remains unchecked because this is a bug fix without a user-facing release-note entry. The branch is ready for maintainer review; please let me know if any template, test, or implementation adjustment is still needed. |
203f9fe to
1b1a00f
Compare
|
Rebased onto the current main branch and re-ran the focused and package tests. |
Describe the pull request
Fix repository markdown links that intentionally point to wiki pages, for example
wiki/Home, so they resolve to the repository wiki instead of being treated as source-relative repository paths.The change keeps normal source-relative links under the repository source path and adds focused regression coverage for wiki links rendered from repository markdown.
Link to the issue: #2851
Checklist
Test plan
GOMODCACHE=/private/tmp/gogs-2851-gomodcache GOCACHE=/private/tmp/gogs-2851-gocache GOPROXY=https://goproxy.cn,direct GOSUMDB=off go test -timeout 90s ./internal/markup -run Test_MarkdownRepoSourceWikiLinks -count=1 -vGOMODCACHE=/private/tmp/gogs-2851-gomodcache GOCACHE=/private/tmp/gogs-2851-gocache GOPROXY=https://goproxy.cn,direct GOSUMDB=off go test -timeout 120s ./internal/markup -count=1git diff --check HEAD~1..HEAD