fix(python-sdk): preserve api_url path prefix in _build_url (fixes #4339) - #4408
Open
AbhiPra24 wants to merge 2 commits into
Open
fix(python-sdk): preserve api_url path prefix in _build_url (fixes #4339)#4408AbhiPra24 wants to merge 2 commits into
AbhiPra24 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4339
Description
When self-hosted Firecrawl is deployed behind a reverse proxy with a path prefix (e.g.
api_url = "http://firecrawl.example.com/firecrawl"),_build_urlpreviously usedurljoin(base_str, endpoint)with endpoints like"/v2/search". In Python'surllib.parse.urljoin, leading slashes in relative endpoint paths replace the base URL's entire path component, dropping/firecrawland sending requests tohttp://firecrawl.example.com/v2/search.This PR fixes
_build_urlinHttpClientto:test_http_client.pycovering standard URLs, trailing slash variants, path prefixes, nested prefixes, query params, and domain normalization.Verification