Skip to content

Replace non-ASCII µs suffix in telemetry metric names - #4776

Open
alco wants to merge 5 commits into
mainfrom
fix-non-ascii-telemetry-metric-names
Open

Replace non-ASCII µs suffix in telemetry metric names#4776
alco wants to merge 5 commits into
mainfrom
fix-non-ascii-telemetry-metric-names

Conversation

@alco

@alco alco commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Renames the microsecond-unit suffix used by several telemetry metric and span-attribute names from the non-ASCII µs/μs characters to plain-ASCII us, since backends such as Mimir/Prometheus reject metric names containing non-ASCII characters and were dropping these metrics on ingestion.
  • Covers the shape DB connection pool checkout queue-time metric named directly in the issue, plus several interval/span-duration attribute names elsewhere in the sync-service that used the same non-ASCII suffix, for consistency.
  • Adds coverage confirming the renamed metric is exported with a plain-ASCII name.

Fixes #4732

@codecov

codecov Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.10%. Comparing base (dc07a1e) to head (33166a4).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4776      +/-   ##
==========================================
+ Coverage   60.02%   60.10%   +0.08%     
==========================================
  Files         397      409      +12     
  Lines       43772    44241     +469     
  Branches    12588    12589       +1     
==========================================
+ Hits        26272    26592     +320     
- Misses      17418    17568     +150     
+ Partials       82       81       -1
Flag Coverage Δ
electric-telemetry 64.39% <ø> (?)
elixir 64.39% <ø> (?)
packages/agents 72.64% <ø> (ø)
packages/agents-mcp 77.70% <ø> (ø)
packages/agents-mobile 80.67% <ø> (ø)
packages/agents-runtime 83.73% <ø> (+0.01%) ⬆️
packages/agents-server 75.67% <ø> (+0.20%) ⬆️
packages/agents-server-ui 8.32% <ø> (ø)
packages/electric-ax 51.06% <ø> (ø)
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/start 82.83% <ø> (ø)
packages/typescript-client 91.95% <ø> (+0.11%) ⬆️
packages/y-electric 56.05% <ø> (ø)
typescript 60.06% <ø> (+0.04%) ⬆️
unit-tests 60.10% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alco
alco marked this pull request as ready for review August 26, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Open telemetry rejected by Mimir/Prometheus

1 participant

@alco