Support enableCleartextPlugin for MySQL connections - #1554
Open
theshreydhiman wants to merge 1 commit into
Open
Conversation
mysql2 3.22.0 disabled the mysql_clear_password auth plugin by default. That breaks two paths that both rely on it: PAM/LDAP-backed MySQL auth, and DBGate's own AWS IAM auth, which passes the IAM token as a cleartext password over a connection that already requires SSL. Add a per-connection 'enableCleartextPlugin' toggle, thread it through to the mysql2 connection options, expose it as an ENABLE_CLEARTEXT_PLUGIN_<id> env var alongside the other per-connection settings, and turn it on automatically when authType is awsIam so existing IAM-auth connections keep working without the user having to discover and flip a new setting. Fixes dbgate#1544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mysql2 3.22.0 disabled the mysql_clear_password auth plugin by default. That breaks two paths that both rely on it: PAM/LDAP-backed MySQL auth, and DBGate's own AWS IAM auth, which passes the IAM token as a cleartext password over a connection that already requires SSL.
Add a per-connection 'enableCleartextPlugin' toggle, thread it through to the mysql2 connection options, expose it as an
ENABLE_CLEARTEXT_PLUGIN_ env var alongside the other per-connection settings, and turn it on automatically when authType is awsIam so existing IAM-auth connections keep working without the user having to discover and flip a new setting.
Fixes #1544