Add Traditional Chinese (Taiwan) localization - #1496
Open
EvenC-tw wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Traditional Chinese (Taiwan) locale (zh-TW) to the web UI, including browser-locale mapping so Traditional Chinese variants resolve to the new translation without changing the existing generic zh locale.
Changes:
- Added a new
translations/zh-TW.jsontranslation bundle. - Registered
zh-TWin the web translation registry and added locale mapping for Traditional Chinese browser locales. - Exposed
zh-TWin the language selector and the translations CLI language-name map.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| translations/zh-TW.json | Adds a full Traditional Chinese (Taiwan) translation bundle. |
| packages/web/src/translations.ts | Registers zh-TW and updates browser-locale detection/mapping. |
| packages/web/src/settings/GeneralSettings.svelte | Adds zh-TW as a selectable UI language. |
| common/translations-cli/translate.js | Adds a human-readable name for zh-TW.json for the translation CLI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a separate Traditional Chinese (Taiwan) localization as
zh-TW.This keeps the existing generic
zhlocalization unchanged, and maps Traditional Chinese browser locales such aszh-TW,zh-Hant, andzh-Hant-TWto the newzh-TWtranslation.Changes
translations/zh-TW.jsonzh-TWto the web translation mapzh-TWzh-TW.jsonto the translation CLI language namesValidation
yarn translations:checkyarn build:webNotes
The translation was based on
translations/en.jsonas the source text.Related to #842