[POC] DABs AIR native fields - #6428
Open
vinchenzo-db wants to merge 4 commits into
Open
Conversation
…git ref
Proposal for AIR-on-DABs code_source parity (see DABs x AIR CLI Alignment).
Extends the existing `artifacts` block so DABs can build the code tarball itself
instead of only uploading a user build command's output:
artifacts:
code_source:
type: tgz # new ArtifactType (was whl|jar)
include: [src/...] # subpaths to pack, gitignore-honored
git: {branch|commit} # snapshot a ref instead of the working tree
files: [{source: ./dist/code.tgz}]
`build` and `git`/`include` are mutually exclusive: either the user's command
produces the tarball (today's behavior) or DABs does. The produced file flows
through the existing artifact upload path, so an ai_runtime_task's
code_source_path pointing at it is uploaded and rewritten to the remote path
with no new reference syntax.
- include: reuses the bundle sync walker (matches file-sync filtering)
- git: shells out to `git archive`
Verified end-to-end on staging (both modes deploy; code_source_path rewritten).
Open for review: this is a proposal to react to, not a finished feature.
jsonschema annotations for the new fields are a follow-up.
Co-authored-by: Isaac
Contributor
Approval status: pending
|
- annotations.yml: descriptions for the new `include`/`git` (+ branch/commit) fields and `tgz` type, so TestRequiredAnnotationsForNewFields passes. - jsonschema.json: regenerated (adds include/git/ArtifactGit/tgz; scoped diff). - validate/strict acceptance golden: artifact type enum now [whl jar tgz]. All bundle/... unit tests, go vet, and the artifacts+validate acceptance subsets pass. Co-authored-by: Isaac
- tarball.go: use errors.New for the no-args git error (perfsprint lint). - jsonschema.json: regenerated post-merge; picks up the variable-ref regex the newer generator emits (validate-generated). Co-authored-by: Isaac
Collaborator
Integration test reportCommit: f2a8fd9
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for AIR-on-DABs code_source parity (see DABs x AIR CLI Alignment). Extends the existing
artifactsblock so DABs can build the code tarball itself instead of only uploading a user build command's output:buildandgit/includeare mutually exclusive: either the user's command produces the tarball (today's behavior) or DABs does. The produced file flows through the existing artifact upload path, so an ai_runtime_task's code_source_path pointing at it is uploaded and rewritten to the remote path with no new reference syntax.git archiveVerified end-to-end on staging (both modes deploy; code_source_path rewritten).Open for review: this is a proposal to react to, not a finished feature. jsonschema annotations for the new fields are a follow-up.
Co-authored-by: Isaac
Changes
Why
Tests
Show that the include field is respected, we notice the
./dist/code.tgzis properly uploaded.Show that git refs are respected: