vm-device: Always zero fill the PIO/MMIO data buffer - #8817
Open
rbradford wants to merge 1 commit into
Open
Conversation
rbradford
force-pushed
the
202608/always-fill-pio-read
branch
from
August 28, 2026 15:04
d988c4e to
bbc0031
Compare
rbradford
enabled auto-merge
August 28, 2026 15:08
phip1611
reviewed
Aug 28, 2026
rbradford
force-pushed
the
202608/always-fill-pio-read
branch
from
August 28, 2026 15:51
bbc0031 to
98da219
Compare
This aligns with the QEMU, Firecracker and CrosVM behaviour and means that a PIO or MMIO read will not see the old data from the kernel's kvm_run struct. There was special case hanlding for the ACPI CPU controller so move it to the common bus implementation. Signed-off-by: Rob Bradford <rbradford@meta.com>
rbradford
force-pushed
the
202608/always-fill-pio-read
branch
from
August 28, 2026 16:01
98da219 to
109040d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns with the QEMU, Firecracker and CrosVM behaviour and means
that a PIO read will not see the old data from the kernel's kvm_run
struct.
There was special case hanlding for the ACPI CPU controller so move it
to the common bus implementation.
Signed-off-by: Rob Bradford rbradford@meta.com