Fix character font lock - #588
Merged
Merged
Conversation
Contributor
Author
|
I also propose moving the |
Member
|
You'll have to check this. The font-locking logic is quite brittle. The changes you proposed look reasonable. Please, mention the fix in the changelog. |
When inside a vector or before white space, some escaped characters, like comma, square and curly brackets, weren't being formatted. * Added tests. * Added examples in test.clj for visual inspection.
rvlo
force-pushed
the
fix-character-font-lock
branch
from
May 4, 2021 13:23
7274062 to
f0eee5a
Compare
Contributor
Author
|
I added a test for the % character literal, moved the |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Characters escaped weren't being formatted correctly, as shown by the submitted test.
Example of code that wasn't being formatted:
["text" \, "other"]
(str \[ "inside" \])
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!