Provide test cases for --list - #1874
Open
casr wants to merge 6 commits into
Open
Conversation
Member
|
Super, thanks 👍 the test looks good to me from just eyeballing it, not sure off the top of my head if the order is guaranteed. I think the solution to this problem will involve setting the |
Author
|
Thank you for having a look and a good note about ordering. I guess I could sort before comparing in the test unless the ordering is guaranteed elsewhere. I will add a note if I find that to be the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before attempting to fix this I thought I would provide a test for the current behaviour and one for the failing behaviour from #1873
It would be good to understand if this is the right approach to testing this sort of thing.
Before merging it might be nice to fix the feature but if this takes longer than expected then one test can go in and the other be skipped until someone has the time to fix it