Port a batch of improvements from neocaml - #18
Merged
Conversation
Scope scroll restoration to the window actually showing the buffer so format-on-save during a non-interactive save can't disturb an unrelated window, and only treat an integer exit code of 0 as success (call-process returns a string when the process is signalled). Also require cl-lib explicitly for the project.el cl-defmethods rather than relying on a transitive require.
fsharp-ts-repl--buffer returns a buffer name, which need not name a live buffer; clear-buffer now errors cleanly instead of signalling from with-current-buffer when no REPL is running. The flavor-mismatch prompt no longer fires (showing nil) when the running REPL's flavor is unknown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports a batch of improvements that landed in the sibling neocaml mode over the last few months, adapting them where F# differs from OCaml.
Highlights:
fsharp-ts-format-buffer,C-c C-f) with optional format-on-saveproject.elintegration for.sln/.slnx/.fsprojprojectsdotnet/fsharpi), restart, a REPL buffer menu,send-definition-and-step, and a#r "nuget:"helperTwo things were adapted rather than copied verbatim: neocaml's
;;-phrase stepping became definition stepping (F# source has no;;delimiters), and#requirebecame#r "nuget: ...".Tests and docs included; byte-compile is clean with
--warnings-as-errorsand the linters pass.