Skip to content

More robust crux-copy-file-preserve-attributes - #100

Merged
bbatsov merged 1 commit into
bbatsov:masterfrom
fredericgiquel:rewrite-copy-file-preserve-attributes
Feb 23, 2024
Merged

More robust crux-copy-file-preserve-attributes#100
bbatsov merged 1 commit into
bbatsov:masterfrom
fredericgiquel:rewrite-copy-file-preserve-attributes

Conversation

@fredericgiquel

Copy link
Copy Markdown
Contributor

crux-copy-file-preserve-attributes suffers from several problems:

  • A new buffer is always opened without correctly taking into account the value of universal argument
  • If filename is different, the new opened buffer contains the source file (destination file in same directory) or an empty buffer (destination file in other directory)
  • If the destination chosen by user is a complete path (with filename) in a non-existent directory, the function fails with error "Opening output file: No such file or directory"

So I rewrote the function in a more robust way to to limit mishandled cases.

@bbatsov
bbatsov merged commit df476a7 into bbatsov:master Feb 23, 2024
@bbatsov

bbatsov commented Feb 23, 2024

Copy link
Copy Markdown
Owner

Thanks and sorry for the slow response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants