Skip to content

test(bdd): add stream CRUD coverage for Rust and Java - #3875

Merged
hubcio merged 5 commits into
apache:masterfrom
Jamison929611:test-bdd-stream-crud-rust-java
Aug 18, 2026
Merged

test(bdd): add stream CRUD coverage for Rust and Java#3875
hubcio merged 5 commits into
apache:masterfrom
Jamison929611:test-bdd-stream-crud-rust-java

Conversation

@Jamison929611

@Jamison929611 Jamison929611 commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR address?

Part of #3609

Rationale

The BDD roadmap tracks client-visible stream CRUD coverage, but there was no shared feature exercising the lifecycle across SDKs.

What changed?

This adds five independent scenarios for creating a stream, retrieving it by numeric ID, finding it in the stream list, renaming it, and deleting it. Rust and Java step definitions use their existing client abstractions, and focused runner paths cover normal and coverage executions.

The review follow-up extracts shared Rust step helpers and centralizes unsupported-SDK handling in the BDD runner.

Local Execution

  • cargo fmt --all -- --check
  • cargo clippy -p bdd --features bdd --all-targets -- -D warnings
  • cargo test -p bdd --features bdd --no-run
  • gradle --no-daemon spotlessCheck testClasses in bdd/java
  • git diff --check

AI Usage

  1. Which tools? OpenAI Codex
  2. Scope of usage? Issue and PR analysis, implementation assistance, review feedback handling, and verification.
  3. How did you verify the generated code works correctly? Rust formatting, clippy, and test-target compilation; Java Spotless and test-class compilation; and Linux CI for the server-backed Rust and Java BDD scenarios.
  4. Can you explain every line of the code if asked? Yes.

@Jamison929611
Jamison929611 marked this pull request as ready for review August 13, 2026 03:50
@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 13, 2026
@Jamison929611

Jamison929611 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

The pre-merge and PR title workflows are currently waiting for first-time contributor approval. Could a maintainer approve the workflow runs when convenient? The focused Rust and Java compile, formatting, lint, and Cucumber dry-run checks pass locally.

chengxilo
chengxilo reviewed Aug 13, 2026
View reviewed changes

@chengxilo chengxilo left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small issue.

One thing worth noting is that we don't have the logic to clean up the stream/topic/user.... we created in the process (not introduced by this PR)

P.S. Please make sure to use the PR template for your description. it's a huge help!

Comment thread bdd/rust/tests/steps/streams.rs Outdated
Comment thread scripts/run-bdd-tests.sh Outdated
@Jamison929611

Jamison929611 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Updated the PR description to the current template. Resource cleanup is a pre-existing cross-feature gap, so it remains outside this focused stream CRUD coverage change.

@chengxilo

chengxilo commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

It might be a bit late to bring this up, but I double-checked the Java BDD tests and it seems that each .feature has its own .java file to define the steps. Because of this, it might be worth separating the steps from BasicMessaging.java into something like StreamCRUD.java.

This probably warrants confirmation from someone more familiar with the Java SDK.

Except that, LGTM

@slbotbm

slbotbm commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Java code LGTM. Rust as well.

numinnex
numinnex previously approved these changes Aug 17, 2026
View reviewed changes
spetz
spetz previously approved these changes Aug 17, 2026
View reviewed changes
@Jamison929611
Jamison929611 dismissed stale reviews from spetz and numinnex via 9bc89c2 August 18, 2026 02:28
@Jamison929611
Jamison929611 force-pushed the test-bdd-stream-crud-rust-java branch from 9bc89c2 to 0b2c24b Compare August 18, 2026 02:30
@Jamison929611

Jamison929611 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Hi maintainers, I've updated the branch with the latest target branch. The previous approvals were automatically dismissed after the update, and the latest checks are passing. Could you please re-approve this PR when you have a chance? Thanks!

hubcio
hubcio previously approved these changes Aug 18, 2026
View reviewed changes
jiangzhen added 4 commits August 18, 2026 19:51
jiangzhen
test(bdd): cover stream CRUD in Rust and Java
2a2301f 
Add shared client-visible scenarios for creating, retrieving, listing, updating, and deleting streams. Wire the Rust and Java implementations into focused and coverage BDD runs.
jiangzhen
refactor(bdd): address stream CRUD review feedback
d684703
jiangzhen
fix(bdd): pass stream update options
c0725b2
jiangzhen
fix(bdd): propagate Java coverage failures
fe5b9b9
@Jamison929611
Jamison929611 force-pushed the test-bdd-stream-crud-rust-java branch from 7de20d9 to fe5b9b9 Compare August 18, 2026 11:56
@Jamison929611

Jamison929611 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Updated the branch with the latest master and fixed the Java coverage command so Gradle failures are propagated correctly. Local Rust BDD compilation, clippy, and Java formatting/test compilation pass. The new workflow runs are awaiting approval.

@hubcio
hubcio merged commit c9d38ee into apache:master Aug 18, 2026
40 checks passed
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Aug 18, 2026
This was referenced Aug 18, 2026
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chengxilo chengxilo chengxilo left review comments
@spetz spetz spetz approved these changes
@hubcio hubcio hubcio approved these changes
@numinnex numinnex numinnex left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Jamison929611 @chengxilo @slbotbm @spetz @hubcio @numinnex